NHMA-35 - Automatic "access" attribute calculation#2
Open
Toshik wants to merge 5 commits intonhibernate:masterfrom
Open
NHMA-35 - Automatic "access" attribute calculation#2Toshik wants to merge 5 commits intonhibernate:masterfrom
Toshik wants to merge 5 commits intonhibernate:masterfrom
Conversation
…plicit ("field"/"property" values are now supported)
Toshik
changed the title
Contributor
Author
|
I am not too familiar with pull requests. Last commit 7f560ea should not be in that request :) |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Ok, here it is: https://nhibernate.jira.com/browse/NHMA-35 |
Proper condition for "access" attribute auto generation
hazzik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually you should specify "access" attribute.
There are mapping errors when someone refactors code and converts field to/from property and forgets to change attribute value.
There is some automatisation:
It works for all attribute types except ComponentAttribute, there you should specify "access" manually.